[Bug 786954] gst-validate scenarios case fail on DRM mode.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 31 07:09:57 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786954

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358796|none                        |reviewed
             status|                            |

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 358796:
 --> (https://bugzilla.gnome.org/review?bug=786954&attachment=358796)

Just a question, besides that it lgtm.

::: gst/vaapi/gstvaapisink.c
@@ +1343,2 @@
   gst_vaapisink_ensure_colorbalance (sink);
   gst_vaapisink_ensure_rotation (sink, FALSE);

Is it required to ensure display's color-balance and rotation before bail out?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list