[Bug 786954] gst-validate scenarios case fail on DRM mode.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Aug 31 18:04:38 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=786954
--- Comment #9 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #7)
> Review of attachment 358796 [details] [review]:
>
> Just a question, besides that it lgtm.
>
> ::: gst/vaapi/gstvaapisink.c
> @@ +1343,2 @@
> gst_vaapisink_ensure_colorbalance (sink);
> gst_vaapisink_ensure_rotation (sink, FALSE);
>
> Is it required to ensure display's color-balance and rotation before bail
> out?
Ideally not, we invoke them in render_frame routine too. But I think it is
better to follow the same code path for all display servers except that drm
won't be doing any "rendering" by itself so that the structure attributes will
show correct values even if it is not using anywhere.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list