[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #11 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #9)
> (In reply to Hyunjun Ko from comment #7)
> > (In reply to Nicolas Dufresne (stormer) from comment #4)
> > Thanks for the detailed review, Nicolas :)
> > I reworked following your comments, but
> > 
> > > Review of attachment 364259 [details] [review] [review] [review]:
> > > 
> > > 
> > > @@ +187,3 @@
> > > +        GST_VIDEO_INFO_WIDTH (info), GST_VIDEO_INFO_HEIGHT (info));
> > > +    vmeta->map = gst_video_meta_map_msdk_memory;
> > > +    vmeta->unmap = gst_video_meta_unmap_msdk_memory;
> > > 
> > > I strongly discourage using these two functions. Any reason why the
> > > map/unmap from the memory does not work ? Are your offsets wrong maybe ?
> > > 
> > 
> > The pipeline (videotestsrc ! msdkenc ) is not working properly if I don't
> > override video meta map/unmap methods.
> > IIUC, videoinfo in videotestsrc seems not to care about the alignment.
> 
> It means you have a bug in your offsets / strides array which you are
> hacking away with this. I'll be very stiff on this, I want to deprecate this
> two functions pointers.

I mean videotestsrc can't do gst_video_frame_map correctly when it's filling
since it uses plain GstVideoInfo just following the caps (not with alignment)

--- Comment #12 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Hyunjun Ko from comment #11)
> > 
> > It means you have a bug in your offsets / strides array which you are
> > hacking away with this. I'll be very stiff on this, I want to deprecate this
> > two functions pointers.
> 
> I mean videotestsrc can't do gst_video_frame_map correctly when it's filling
> since it uses plain GstVideoInfo just following the caps (not with alignment)

Please let me know if there's something that I don't understand correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.