[Bug 790999] only vaapisink should query for app context

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Dec 1 13:11:12 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790999

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364675|none                        |needs-work
             status|                            |

--- Comment #5 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364675:
 --> (https://bugzilla.gnome.org/review?bug=790999&attachment=364675)

::: gst/vaapi/gstvaapipluginutil.c
@@ +283,3 @@
+      if (GST_IS_VIDEO_SINK (element)) {
+        /* Propagate if display was created from application */
+        gst_vaapi_video_context_propagate (element, plugin->display);

This is wrong. If the sink find a GstVaapiDisplay in upstream, it will
propagate it again, which is not intended.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list