[Bug 790999] only vaapisink should query for app context

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Dec 1 22:11:39 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790999

--- Comment #8 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Created attachment 364793
  --> https://bugzilla.gnome.org/attachment.cgi?id=364793&action=edit
vaapivideocontext: only vaapisink process app context

gst.vaapi.app.Display context is made for applications that will
provide the VA display and the native display to used by the
pipeline, when are using vaapisink as overlay. There are no use
case for encoders, decoders, neither for the postprocessor.

In the case of the vaapisink, it shall query for gst.vaapi.Display
upstream first, and then, if there is no reply,
gst.vaapi.app.Display context will be posted in the bus for the
application. If the application replies, a GstVaapiDisplay object
is instantiated given the context info, otherwise a
GstVaapiDisplay is created with the normal algorithm to guess the
graphics platform. Either way, the instantiated GstVaapiDisplay
is propagated among the pipeline and the have-message bus message.

Also only vaapisink will process the gst.vaapi.app.Display, if
and only if, it doesn't have a display already set. This is
caused because if vaapisink is in a bin (playsink, for example)
the need-context is posted twice, leading to an error state.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list