[Bug 790473] kmssink: Does not copy metas as needed from parent buffers when importing dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790473

--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Haihua Hu from comment #13)
> (In reply to Nicolas Dufresne (stormer) from comment #12)
> > Review of attachment 364248 [details] [review] [review]:
> > 
> > TO me this one is the right fix. Is there anything not covered ?
> 
> if support overlay interface, then show_frame() call will input NULL buffer
> for refresh, as a result, get meta will fail.

That cannot happen because

  if (buf)
    buffer = gst_kms_sink_get_input_buffer (self, buf);
  else if (self->last_buffer)
    buffer = gst_buffer_ref (self->last_buffer);

  if (!buffer)
    return GST_FLOW_ERROR;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.