[Bug 739010] Move GstAggregator from -bad to gstreamer (core)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739010

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.13.1
            Summary|[PLUGIN MOVE] Move          |Move GstAggregator from
                   |GstAggregator to gstreamer  |-bad to gstreamer (core)
                   |(core)                      |

--- Comment #50 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
1) Follow up bugs:

Bug #791201 - better support for static input pads
Bug #791202 - need gst_aggregator_pad_set_waiting() for sparse streams


2) I'm still very much inclined towards renaming

 gst_aggregator_pad_steal_buffer() -> gst_aggregator_pad_pop_buffer()
 gst_aggregator_pad_get_buffer() -> gst_aggregator_pad_peek_buffer()

It is true that get/steal is used elsewhere, but in a slightly different
context. I think pop/peek describe what is done functionality-wise much better
and avoid confusion about the return value ownership, e.g. with GValue _get()
will not return a ref whereas _steal() will but here both do return a ref.


3) Tag handling is bogus. I think I will just remove it, don't think any of the
current subclasses is using that at the moment, then we can figure out what to
do once someone needs it and can't handle it via the usual vfuncs.


Otherwise this is done, so let's close it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.