[Bug 791204] New: aggregator: rename pad_{get,steal}_buffer() to pad_{peek,pop}_buffer()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791204

            Bug ID: 791204
           Summary: aggregator: rename pad_{get,steal}_buffer() to
                    pad_{peek,pop}_buffer()
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: blocker
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: t.i.m at zen.co.uk
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

>From bug #739010:

I'm still very much inclined towards renaming

 gst_aggregator_pad_steal_buffer() -> gst_aggregator_pad_pop_buffer()
 gst_aggregator_pad_get_buffer() -> gst_aggregator_pad_peek_buffer()

It is true that get/steal is used elsewhere, but in a slightly different
context. I think pop/peek describe what is done functionality-wise much better
and avoid confusion about the return value ownership, e.g. with GValue _get()
will not return a ref whereas _steal() will but here both do return a ref.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.