[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #24 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #22)
> Review of attachment 364889 [details] [review]:
> @@ +405,3 @@
> +
> +gint
> +msdk_get_mfx_fourcc (GstVideoFormat format)
> 
> This function is useless since we already have gst_video_format_to_fourcc ()
> 

Using gst_video_format_to_fourcc causes failure of vpp.(in case of I420 and
BGRA)
Seems that the required fourcc for the driver might be different.


> @@ +440,3 @@
> +  mfx_info->AspectRatioW = info->par_n;
> +  mfx_info->AspectRatioH = info->par_d;
> +  mfx_info->PicStruct = MFX_PICSTRUCT_PROGRESSIVE;
> 
> you can get this also from the gstvideoinfo:
> 
> info->interlace_mode

I want to set MFX_PICSTRUCT_PROGRESSIVE by default.
Because the values of GstVideoInterlaceMode and values of MFX_PICSTRUCT are
very different. Probably the PicStruct might be set when needed after this
call.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.