[Bug 791211] omxvideodec/enc: update nBufferCountActual before allocating

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Dec 5 12:05:14 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=791211

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364916|none                        |rejected
             status|                            |

--- Comment #6 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 364916:
 --> (https://bugzilla.gnome.org/review?bug=791211&attachment=364916)

::: omx/gstomxvideodec.c
@@ +2137,3 @@
 gst_omx_video_dec_allocate_in_buffers (GstOMXVideoDec * self)
 {
+  if (!gst_omx_port_ensure_buffer_count_actual (self->dec_in_port))

Humm looks like this breaks omxh264dec on the pi :(
Its input port has nBufferCountActual=20 as default but nBufferCountMin=1
(which is a violation of the spec). And the component isn't working with only
one buffer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list