[Bug 791271] v4l2videodec: padding removal only works if the driver extends both width and height

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791271

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365034|none                        |reviewed
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 365034:
 --> (https://bugzilla.gnome.org/review?bug=791271&attachment=365034)

This seems fair, though I notice that in v4l2object.c we make up the padding
from the stride instead of simply looking the at the composition data. I can't
remember or find any reason why we need to calculate that. We could simply keep
whatever is considering "padding" from the SELECTION separate from the padding
introduce by the stride, and then the driver should be coherant, keeping this
code simpler. I'm just asking for feedback, I think the code is correct though
(just a bit hairy).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.