[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #45 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Hyunjun Ko from comment #44)

> > 
> > @@ +959,3 @@
> > +            msdk_get_free_surface (thiz->vpp_surfaces,
> > thiz->num_vpp_surfaces);
> > +      else
> > +        surface = msdk_get_free_surface (thiz->surfaces,
> > thiz->num_surfaces);
> > 
> > all these free surfaces shall be handled, in my opinion, by the bufferpool,
> > because this is a buffer pool.
> > 
> > The problem here is the use of VPP... perhaps we could move that logic into
> > the bufferpool.. dunno...
> > 
> > The interesting part here it that we could reuse the input buffer avoiding a
> > memcopy. For that we could use GstBufferPoolAcquireFlags in
> > GstBufferPoolAcquireParams saying "don't allocate memory, just grab the
> > surface"
> > 
Thanks for good advice, I think I should implement acquire_buffer in msdk
bufferpool to do that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.