[Bug 765275] matroska: Add encrypted content support in matroskademux
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Dec 6 15:30:40 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=765275
--- Comment #34 from y.bandou <bandou.yacine at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #28)
> Review of attachment 361953 [details] [review]:
>
> @@ +543,3 @@
> + gst_buffer_unref (buf_sub_sample);
> + } else {
> + gst_structure_set (info_protect, "subsample_count", G_TYPE_UINT, 0,
> NULL);
>
> Underscore instead of dash
>
> @@ +3100,3 @@
> +
> + context->protection_info =
> + gst_structure_new ("application/x-cenc", "iv_size",
>
> We usually use dashes instead of underscores in structure field names
Currently, in qtdemux we use underscore instead of dash in protection event
structure.
see qtdemux.c:2803, qtdemux.c:9569.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list