[Bug 790042] waylandsink: memory leak of shm allocator

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 7 01:45:01 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790042

--- Comment #3 from Shinya Saito <ssaito at igel.co.jp> ---
Thank you for accepting patches.

However, it seems that the correction has not been reflected correctly.


commit 816d115317c522c87297109de781c63b16146493

@@ -579,8 +582,10 @@ gst_wayland_sink_propose_allocation (GstBaseSink * bsink,
G
stQuery * query)
   if (pool)
     g_object_unref (pool);

+  alloc = gst_wl_shm_allocator_get ();
   gst_query_add_allocation_param (query, gst_wl_shm_allocator_get (), NULL);
   gst_query_add_allocation_meta (query, GST_VIDEO_META_API_TYPE, NULL);
+  g_object_unref (alloc);


Since the previous gst_wl_shm_allocator_get() remains, this patch can not fix
the leak. This part should be replaced with the alloc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list