[Bug 781721] inter: Add overflow-mode property and alternative "block" mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781721

--- Comment #4 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
> Flush seems like a weird name. It's "non-blocking", it does not flush :)

I called it flush because of the gst_adapter_flush() call in interaudiosink,
but perhaps this is too specific. What about "overwrite-oldest"?

> What is this case and why do we wait for preroll here? Needs a comment.

This follows the GstBaseSink unlock() documentation, which states: "Subclasses
should unblock any blocked function ASAP and call gst_base_sink_wait_preroll()"

> You need to detect the unlock/flushing case here, in which case you want to go out immediately.

This actually already happens. In the unlock/flushing case, the unlock() vfunc
is called, which sets the unlocked flag and signals the condition variable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.