[Bug 791331] x264enc: add 'use-vui' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791331

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365179|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 365179:
 --> (https://bugzilla.gnome.org/review?bug=791331&attachment=365179)

Patch is good, I just don't like the use-vui name as we're not using a VUI,
we're creating and inserting it (hence the propose rename to "insert-vui")

::: ext/x264/gstx264enc.c
@@ +943,3 @@
+  g_object_class_install_property (gobject_class, ARG_SLICED_THREADS,
+      g_param_spec_boolean ("use-vui", "Use VUI",
+          "Use VUI when encoder is initialized",

Description should be somethign like "Insert VUI NAL in stream", and maybe the
name of the param should be something like "insert-vui"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.