[Bug 790762] rtpsession: do not report internal sources
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Sat Dec 9 19:33:37 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=790762
--- Comment #14 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Hello Håvard and Sebastian,
first of all thanks for helping with this RtpSession issues.
Regarding using GstHarness, I totally agree with Håvard, using it makes tests
quite easier. Actually, I used it in the new tests I did for RtpSession.
Hence, I will rebase my changes onto the test refactoring and I will use the
SessionHarness abstraction.
Apart of that, I am happy that we both have found and fixed the issue
independently, which demonstrates that there was a really bug.
In relation to your fix, I am not sure if removing the next check could cause
an unexpected behavior, we should check it:
- /* only report about other sender */
- if (source == data->source)
Anyway, independently your solution or mine is merged I would add both tests to
have a wider coverage.
Could you please attach your patches here?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list