[Bug 790661] rtpsession: fix allow_early flag for RTCP early handling

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Dec 9 19:41:47 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790661

--- Comment #14 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Yes, I have taken a look to revision [1] but I think it will need some extra
work to make it totally deterministic due to the next function could cause
generating more than num_rtcp_packets

static void
session_harness_produce_rtcp (SessionHarness * h, gint num_rtcp_packets)
{
  /* due to randomness in rescheduling of RTCP timeout, we need to
     keep cranking until we have the desired amount of packets */
  while (gst_harness_buffers_in_queue (h->rtcp_h) < num_rtcp_packets)
    session_harness_crank_clock (h);
}

The ideal would be crank and wait until having the desired RTCP packets.
I will work on it when I have a time slot ;)

Refs
[1] https://bugzilla.gnome.org/review?bug=791070&attachment=364744

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list