[Bug 791453] videocrop: Add GstVideoCropMeta support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791453

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365331|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 365331:
 --> (https://bugzilla.gnome.org/review?bug=791453&attachment=365331)

Looks good to me except for the fixate_caps() hack. Is there no better way,
maybe by adding some new API to basetransform? :)

::: gst/videocrop/gstvideocrop.c
@@ +704,3 @@
+    goto done;
+
+  if (!gst_pad_push_event (trans->srcpad, gst_event_new_caps (othercaps)))

gst_base_transform_update_src_caps()? Sending a caps event behind
basetransform's back is probably not a good idea.

@@ +708,3 @@
+
+  query = gst_query_new_allocation (othercaps, FALSE);
+  if (!gst_pad_peer_query (trans->srcpad, query))

And this would cause two allocation queries to be done, with the result of this
one being ignored more or less?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.