[Bug 759043] gst-omx: Timeout waiting for egl_render port 221 buffer release triggers subsequent "Insufficient resources" errors

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=759043

--- Comment #14 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #13)
> Julien, is that patch a replacement or just an extra fix ?

I believe the exact fix for the timeout mentioned in the bug title is
https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=68518acb53d4808cf8352ed4fd1cb8b331553559
. Indeed this should allow to not timeout during the dynamic format change when
using appsink like in webkit. But need confirmation from Enrique.

Along the way we found that the dynamic format change should not happen. Indeed
the resolution does not change, only the framerate changes but very slightly,
i.e. from 50000/1677=29.81 to 89/3=29.66 so a "percentage change" of less than
1% (i.e. 100*(29.81-29.66)/29.66 = 0.50 < 1 ). So the change of the framerate
should be ignored really.

Even worst the framerate would overflow in the first place so let's fix that
first, see attached patch. But I am going to submit a second patch to make the
comparison of the framerate more permissive, i.e. do not consider the framerate
to have changed if the "percentage change" is less than 1%. This future patch
will just avoid an unnecessary renegotiation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.