[Bug 790000] rtph264depay: doesn't update resolution if format is avc

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790000

--- Comment #26 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Olivier Crête from comment #12)
> (In reply to Sebastian Dröge (slomo) from comment #11)
> > > I know this
> > > will be a problem for mp4 file, in that case, h264parse should probably
...

> Afaik, in the AVC1 case, it should renumber and keep them all around until
> the parser/depayloader is reset to READY as this is the only way to make a
> truly valid stream. As I think having "filesrc ! tsdemux! h264parse ! mp4mux
> ! filesink" should produce a single continuous file even if you do flushing
> seeks.

If you renumber SPS/PPS, you also need to change every packet that contains a
reference to the SPS and PPS ids. In any case, that's not how AVC in mp4 works
- it's quite OK to change SPS/PPS on the fly, but the muxer needs to append a
new configuration section and avcC entry, and change the STSD entry for the
samples so the correct SPS/PPS will be activated when that happens.

qtmux doesn't implement that, but qtdemux does - see
gst_qtdemux_stream_check_and_change_stsd_index() in qtdemux.c.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.