[Bug 791453] videocrop: Add GstVideoCropMeta support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791453

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> There are two allocation queries being done now, or not?

If the sub-class decides to passthrough or in-place, it will have run only 1
allocation query.

> And the results to
> both could be different, and the second allocation query is the one we
> actually configure for so anything we got from the first could be invalid.

For no reason in this context the first or the second allocation query should
be invalid. If this happens for you in some of your code, you'll get random
issues really. Remember there is no acknowledgment in this mechanism. The
reason I'm proposing it this way, is to avoid the creation of a pool, so I
optimized for the passthrough/in-place mode.

I guess I could try and move the passthrough/in-place check after the
allocation query, the uneeded bufferpool/allocator will simply be unreffed.
What I wanted to avoid is to steel the buffer pool for single pool downstream
elements (like v4l2 and OMX). But rethinking it, it will just be unreffed,
without being activated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.