[Bug 789316] Add Meson support in cerbero

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789316

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365501|none                        |needs-work
             status|                            |

--- Comment #65 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 365501:
 --> (https://bugzilla.gnome.org/review?bug=789316&attachment=365501)

::: cerbero/build/build.py
@@ +408,3 @@
+        ModifyEnvBase.__init__(self)
+
+        self.meson_dir = os.path.join(self.build_dir, "cerbero-build-dir")

Make this a bit shorter please, think of poor Windows with its limited
capability of handling long paths :)

@@ +413,3 @@
+        if self.config.cross_compiling():
+            self.new_env['CC'] = None
+            self.new_env['CXX'] = None

Why? Maybe the user wanted to build with clang instead of gcc?

@@ +459,3 @@
+        # Take CC and CXX from _old_env because we modified env to make them
be
+        # the native toolchain. If the variable is not set, we assume we want
+        # MSVC

Why? on Windows this might make sense, but not in general

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.