[Bug 790686] matroskamux: re-activate TOC support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790686

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364775|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 364775:
 --> (https://bugzilla.gnome.org/review?bug=790686&attachment=364775)

Generally looks good to me, thanks!

::: gst/matroska/matroska-mux.c
@@ +3355,2 @@
     gst_ebml_replace_uint (ebml, mux->seekhead_pos + 144,
         mux->tags_pos - mux->segment_master);

Should we write another thing here for the tocs?

::: tests/check/elements/matroskademux.c
@@ +137,3 @@
 GST_END_TEST;

+/* Recusively compare 2 toc entries */

typo :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.