[Bug 791617] waylandsink: fix dmabuf import for zwp_linux_dmabuf_v1 interface version 3

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791617

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365545|none                        |rejected
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 365545:
 --> (https://bugzilla.gnome.org/review?bug=791617&attachment=365545)

I have the same patch, but it's just hiding a compositor bug. We properly
advertise version 1 where this new callback does not exist, so it's wrong to
set it.

::: ext/wayland/wldisplay.c
@@ +248,3 @@
   } else if (g_strcmp0 (interface, "zwp_linux_dmabuf_v1") == 0) {
     self->dmabuf =
+        wl_registry_bind (registry, id, &zwp_linux_dmabuf_v1_interface, 3);

Make absolutly no sense to request 3 if we we implement 1. I'll accept moving
forward if something is done with the new feature. Meanwhile, complain to the
respective compositor project.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.