[Bug 790686] matroskamux: re-activate TOC support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 14 18:27:28 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790686

fengalin at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365552|0                           |1
        is obsolete|                            |

--- Comment #16 from fengalin at free.fr ---
Created attachment 365554
  --> https://bugzilla.gnome.org/attachment.cgi?id=365554&action=edit
Rework unit tests after watching suggested talk (more cleanups)

Sorry for the spam, I just found more things that could be improved in the unit
tests.

Lines in the comment from my previous message have shifted. It should now read:

The position for the TOC in the header is replaced in matroska-mux.c @ 3330
AFAIU. This position is used in the unit tests @ 860 and 872. Should it be
incorrectly set, the TOC test would fail as the rest of the checks starts from
this position.

Won't touch this no more, unless you find something else to improve.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list