[Bug 789316] Add Meson support in cerbero

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789316

--- Comment #69 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Xavier Claessens from comment #67)

> > Why do we install via PIP instead of having a recipe? Updating with PIP or
> > ensuring that at least a specific version is used seems less than ideal
> 
> It is actually complicated to have it as recipe because we mix python2 and
> python3 here and we can only set PYTHON_PATH to one of them. It can be work
> around (my initial patches did that) but nirbeek said we should just
> consider meson comes from your system.

I'm fine with that until the py3 port is in, but then please add a recipe for
that.

> (In reply to Sebastian Dröge (slomo) from comment #65)
> > +        self.meson_dir = os.path.join(self.build_dir, "cerbero-build-dir")
> > Make this a bit shorter please, think of poor Windows with its limited
> > capability of handling long paths :)
> 
> Maybe just "builddir" ? We should make sure to not be too generic otherwise
> it would clash with a folder that projects has in git. Like glib has a
> "build" folder.

Maybe "build", and if existing already "build_", "build__", etc? "builddir"
could equally conflict

> So yes, that's an ugly hack, but it makes stuff work. Do you think that's
> merge blocker?

No, but open another Bugzilla bug about that so it's not forgotten. That should
be fixed sooner or later, it's ugly :)

It also seems weird that meson needs the host compiler in the environment. I
thought meson hates environment variables for everything...

> > @@ +459,3 @@
> > +        # Take CC and CXX from _old_env because we modified env to make
> > them be
> > +        # the native toolchain. If the variable is not set, we assume we
> > want
> > +        # MSVC
> > 
> > Why? on Windows this might make sense, but not in general
> 
> That's from nirbeek branch, it defaults to MSVC. CMake default to "gcc"
> which is equaly wrong I guess... We should not even need a default there, in
> practice you should always have a compiler set in your env, no?

Yes, or cerbero should make sure that this is the case. Is this part needed,
and if so, for what exactly?

> (In reply to Sebastian Dröge (slomo) from comment #66)
> > This requires the bootstrap for the cross-win* targets to install wine then
> 
> Do we even ever run target platform binaries? That wasn't supported before,
> not sure we need this. That's from nirbeek. IMO wine is a big and unreliable
> dependency to have. I guess we should test if cross build still works
> without that.

AFAIU meson might do that. autotools does not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.