[Bug 790686] matroskamux: re-activate TOC support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790686

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 3464aac3c9802eff32ce86b29c1f02ab316c5d99 (HEAD -> master, origin/master,
origin/HEAD)
Author: fengalin <fengalin at free.fr>
Date:   Fri Dec 15 14:48:09 2017 +0100

    matroska: fix memory leaks due to toc related updates

    https://bugzilla.gnome.org/show_bug.cgi?id=790686

commit c55824e4fab835f20d1caa463d166e40e5d4d545
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Dec 15 11:40:13 2017 +0200

    matroskamux: Fix various memory leaks in the unit test

    https://bugzilla.gnome.org/show_bug.cgi?id=790686

commit 694c07fe63ed47138f8c1d80dadb96c63ffa7f6c
Author: fengalin <fengalin at free.fr>
Date:   Thu Dec 14 19:05:36 2017 +0100

    matroska-mux: migrate test to gst_harness

    ... following the guide lines from Håvard Graff (see
https://gstconf.ubicast.tv/videos/moar-better-tests/).

    https://bugzilla.gnome.org/show_bug.cgi?id=790686

commit a6702a76d5b4f1f5da99f8ab6a0bae0941e82b6b
Author: fengalin <fengalin at free.fr>
Date:   Fri Dec 1 18:17:06 2017 +0100

    matroska: re-activate and update TOC support

    TOC support in mastroskamux has been deactivated for a couple of years.
This commit updates it to recent GstToc evolutions and introduces toc unit
tests for both matroska-mux and matroska-demux.

    There are two UIDs for Chapters in Matroska's specifications:
    - The ChapterUID is a mandatory unsigned integer which internally refers to
a given chapter. Except for title & language which use dedicated fields, this
UID can also be used to add tags to the Chapter. The tags come in a separate
section of the container.
    - The ChapterStringUID is an optional UTF-8 string which also uniquely
refers to a chapter but from an external perspective. It can act as a "WebVTT
cue identifier" which "can be used to reference a specific cue, for example
from script or CSS".

    During muxing, the ChapterUID is generated and checked for unicity, while
the ChapterStringUID receives the user defined UID. In order to be able to
refer to chapters from the tags section, we maintain an internal Toc tree with
the generated ChapterUID.

    When demuxing, the ChapterStringUIDs (if available) are assigned to the
GstTocEntries UIDs and an internal toc mimicking the toc is used to keep track
of the ChapterUIDs and match the tags with the appropriate GstTocEntries.

    https://bugzilla.gnome.org/show_bug.cgi?id=790686

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.