[Bug 791338] v4l2videoenc: calling S_FMT after REQBUFS fails
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Dec 19 13:18:41 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=791338
Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #365741|none |needs-work
status| |
--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 365741:
--> (https://bugzilla.gnome.org/review?bug=791338&attachment=365741)
So this happens if the is a renegotiation ? Why not fixing that case instead ?
Check is something have actually changed, if not return TRUE, then run the
allocation (to drain) stop the pools, and then set the new format. Just
ignoring the caps seems rather bad.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list