[Bug 791736] wavenc: fix tag and toc handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791736

--- Comment #9 from fengalin at free.fr ---
> The same is true for toc setter btw, the toc should persist
> forever until the application is setting a different one

I think we have an issue with current TOC Setter model:

- There is no merge mode like we have for GstTagSetter.
- Current implementations for wavenc and flacenc store the upstream TOC in a
dedicated GstToc field. We have no way of resetting it from the application.
The application TOC is ignored if an upstream TOC has been received. I would at
least use the application TOC over the upstream TOC.
- In matroska-mux, when a TOC event is received, the element stores it using
the TOC Setter. This behaviour allows resetting the upstream TOC or replacing
it when done in the proper state. However, this doesn't comply with the
persistent nature of the application TOC.

Did I miss something? Should we enhance GstTocSetter in order to be able to
indicate some sort of TOC selection mode (I wouldn't go so far as to propose a
merge mode)? This would match something like:

- GST_TOC_SELECT_UPSTREAM. This would match current behaviour. IMHO it
shouldn't be the default though.
- GST_TOC_SELECT_APPLICATION.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.