[Bug 791841] New: Wrong structure used in gst_v4l2_video_enc_get_property (self->v4l2output instead of self->v4l2capture)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791841

            Bug ID: 791841
           Summary: Wrong structure used in
                    gst_v4l2_video_enc_get_property (self->v4l2output
                    instead of self->v4l2capture)
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: meinemailingliste2 at online.de
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

When looking at gst_v4l2_video_enc_set_property 
(here
https://github.com/GStreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videoenc.c#L61
)
then first and default cases uses

self->v4l2output

second case uses

self->v4l2capture

so far so good.

Same in gst_v4l2_video_enc_get_property
(here
https://github.com/GStreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videoenc.c#L87
)

all three cases use

self->v4l2output

Furthermore
https://github.com/GStreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videoenc.c#L98

uses PROP_IO_MODE instead of prop_id like in all other cases,
which is perhaps not wrong, but breaks symmetry to all other cases.

Similar code seems to be in 

https://github.com/GStreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videodec.c

but there everything is ok.

I am sorry, my knowledge is limited and cannot decide if correct
nor can I create a suitable patch for this. Can someone help?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.