[Bug 739011] [PLUGIN MOVE] Move GstVideoAggregator to gst-plugins-base

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739011

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
A quick .h review let me know that it needs work.

In the Class structure:
>  /* Output caps */
>  GstVideoInfo info;

Comment is wrong, maybe call this src_info or out_info ?

>  GstCaps *          (*update_caps)               (GstVideoAggregator *  videoaggregator,

I'm not sure I understand from reading the doc. I'm sure it's useful though.


>  GstFlowReturn      (*aggregate_frames)          (GstVideoAggregator *  videoaggregator,
                                                   GstBuffer          * 
outbuffer);
>  GstFlowReturn      (*get_output_buffer)         (GstVideoAggregator *  videoaggregator,
                                                   GstBuffer          **
outbuffer);

If one implements both, what does it give over implementing aggregate() ? Just
asking APIs whise. Also, get_output_buffer, should it be something like
allocate_output_buffer ?

>   GstCaps           *sink_non_alpha_caps;

Undocumented, I can barely guess what this is about.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.