[Bug 747606] v4l2: adding cropping and compose functionality

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747606

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301261|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 301261:
 --> (https://bugzilla.gnome.org/review?bug=747606&attachment=301261)

Sorry for taking ages to review this. Note that v4l2_calls.h was merged into
gstv4l2object.h, so this patch won't apply any more.

::: sys/v4l2/gstv4l2object.c
@@ +3822,3 @@
+    type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
+  else
+    type = obj->type;

Hans removed this stupidity, you can just use obj->type on new kernels.

@@ +3838,3 @@
+
+  /* get the cropping bounds */
+  if (v4l2_ioctl (obj->video_fd, VIDIOC_G_SELECTION, &bounds) < 0) {

Did you mean to do something with the bounds ?

@@ +3885,3 @@
+    type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
+  else
+    type = obj->type;

Just use obj->type.

@@ +3901,3 @@
+
+  /* get the compose bounds */
+  if (v4l2_ioctl (obj->video_fd, VIDIOC_G_SELECTION, &bounds) < 0) {

Same question, I don't see anything using the values in bounds.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.