[Bug 786344] audioaggregator: implement input conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786344

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de

--- Comment #17 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
As discussed during the hackfest, these things where meant to be supposed to be
resolved before moving:
@@ -1858,12 +1872,13 @@ gst_aggregator_query_latency_unlocked (GstAggregator *
self, GstQuery * query)

   gst_query_parse_latency (query, &live, &min, &max);

+  // FIXME: this is already done by gst_query_set_latency()
   if (G_UNLIKELY (!GST_CLOCK_TIME_IS_VALID (min))) {
     GST_ERROR_OBJECT (self, "Invalid minimum latency %" GST_TIME_FORMAT
         ". Please file a bug at " PACKAGE_BUGREPORT ".", GST_TIME_ARGS (min));
     return FALSE;
   }
-
+  // FIXME: should this be done by gst_query_set_latency() too?
   if (min > max && GST_CLOCK_TIME_IS_VALID (max)) {
     GST_ELEMENT_WARNING (self, CORE, CLOCK, (NULL),
         ("Impossible to configure latency: max %" GST_TIME_FORMAT " < min %"
@@ -2001,6 +2016,7 @@ gst_aggregator_default_src_query (GstAggregator * self,
GstQuery * query)

       /* don't pass it along as some (file)sink might claim it does
        * whereas with a collectpads in between that will not likely work */
+      // FIXME: wat?    ^^^^^^^^^^^
       gst_query_parse_seeking (query, &format, NULL, NULL, NULL);
       gst_query_set_seeking (query, format, FALSE, 0, -1);
       res = TRUE;


So please exterminate all mentions of collectpads. Those are leftovers, since
the initial code started as a close of collectpads.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.