[Bug 791986] aggregator: add a drain vmethod

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Dec 27 16:16:00 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=791986

Olivier CrĂȘte <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366019|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 366019:
 --> (https://bugzilla.gnome.org/review?bug=791986&attachment=366019)

::: libs/gst/base/gstaggregator.c
@@ +1294,3 @@
+    tmppad = (GstAggregatorPad *) tmp->data;
+
+    if (g_atomic_int_get (&tmppad->priv->pending_segment_done) == TRUE) {

No need for atomic, your holding the object lock of the pad

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list