[Bug 791988] jpeg: Fixup frames without an EOI marker

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791988

--- Comment #1 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 366021:
 --> (https://bugzilla.gnome.org/review?bug=791988&attachment=366021)

Makes sense to me, two trivial remarks. It is annoying that we have to add the
EOI at all, but if you say underlying libraries require one then we don't have
much of a choice :)

::: ext/jpeg/gstjpegdec.c
@@ -1009,3 @@
   G_GNUC_UNUSED GstFlowReturn ret;
   guint r_h, r_v, hdr_ok;
-

No need for that new line :)

@@ +1204,3 @@
+  has_eoi = ((data[nbytes - 2] != 0xff) || (data[nbytes - 1] != 0xd9));
+
+  if (!has_eoi) {

Can you add a brief comment here explaining why we have to do that?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.