[Bug 791986] aggregator: add a drain vmethod

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791986

--- Comment #3 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
(In reply to Olivier Crête from comment #1)
> Review of attachment 366019 [details] [review]:
> 
> ::: libs/gst/base/gstaggregator.c
> @@ +1294,3 @@
> +    tmppad = (GstAggregatorPad *) tmp->data;
> +
> +    if (g_atomic_int_get (&tmppad->priv->pending_segment_done) == TRUE) {
> 
> No need for atomic, your holding the object lock of the pad

I have the OBJECT_LOCK, but not the PAD_LOCK.

(In reply to Mathieu Duponchelle from comment #2)
> Review of attachment 366019 [details] [review]:
> 
> ::: libs/gst/base/gstaggregator.c
> @@ +1412,3 @@
>        aggpad->priv->tail_position = GST_CLOCK_TIME_NONE;
>        update_time_level (aggpad, FALSE);
> +      aggpad->priv->pending_segment_done = priv->segmented_seeking;
> 
> What's "segmented_seeking"?

Something that I missed from splitting out from the changes. Thanks for careful
watching. I'll update the patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.