[Bug 791445] glwindow/cocoa: Implement set_render_rectangle

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Dec 30 11:07:57 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=791445

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365983|none                        |accepted-commit_now
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 365983:
 --> (https://bugzilla.gnome.org/review?bug=791445&attachment=365983)

Only a nit. Otherwise looks fine.

::: gst-libs/gst/gl/cocoa/gstglwindow_cocoa.m
@@ +88,3 @@
     GstGLWindowCB callback, gpointer data, GDestroyNotify destroy);
+static gboolean gst_gl_window_cocoa_set_render_rectangle (GstGLWindow *
+                                                          window, gint x, gint
y, gint width, gint height);

That is some weird formatting :D

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list