[Bug 792034] dmabuf import with icamerasrc plugin does not working with gst-vaapi-1.12.2

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792034

--- Comment #7 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #6)
> (In reply to sreerenj from comment #5)
> > (In reply to Nicolas Dufresne (stormer) from comment #4)
> > Does it mean to remove the "dmabuf-import" option completely from v4l2src (+
> 
> That I can't, it's in the API now.
> 
> > the corresponding code from gstreamer-vaapi)?
> 
> That's the code I'll remove as it's unsafe (or at least make sure it's not
> used without user knowledge of the risk). The fix in the source will cause
> pipeline error in many cases, instead of crash or corrupted image, it's not
> much better.

Tha hack in gstreamer-vaapi is for checking whether user explicitly enabled
upstream element's "io-mode" to "dmabuf-import". Yes, it a super hack, which
was added a long time ago when there were no dmabuf negotiation support in
GStreamer and inherited all the way till 1.12.x.


BTW, good to see "dmabuf-export" as default in v4l2src. Great!
So I am fine with removing the hack for v4l2 from gstreamer-vaapi, but please
keep it for "icamerasrc", hopefully we can add some other fix than the nasty
hack.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.