[Bug 776997] hlsdemux: Implement adaptivedemux's _stream_seek()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 1 11:36:11 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=776997

--- Comment #6 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 343107 [details] [review]:
> 
> Can you split that up into multiple patches? This looks like several changes
> (3?) at once, including

I splinted previous patch into three part :)

> ::: ext/hls/gsthlsdemux.c
> @@ +362,3 @@
> +      (flags & GST_SEEK_FLAG_SNAP_NEAREST) == GST_SEEK_FLAG_SNAP_NEAREST;
> +  snap_before = ! !(flags & GST_SEEK_FLAG_SNAP_BEFORE);
> +  snap_after = ! !(flags & GST_SEEK_FLAG_SNAP_AFTER);
> 
> Refactoring the seek() function generally, mostly be moving code around a bit

Please refer to attachment 344698

> @@ +366,3 @@
> +  if (target_type == GST_SEEK_TYPE_NONE && !(flags & GST_SEEK_FLAG_FLUSH)) {
> +    /* No need to move */
> +    gst_segment_do_seek (&demux->segment, rate, format, flags, start_type,
> 
> Doing nothing if not needed here

Please refer to attachment 344697

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list