[Bug 777506] vaapidecoder_h264: Recursive loop and segfault after a few seconds

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777506

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344837|none                        |reviewed
             status|                            |

--- Comment #10 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 344837:
 --> (https://bugzilla.gnome.org/review?bug=777506&attachment=344837)

nice!

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +3168,3 @@
   priv->frame_num = priv->prev_ref_frame_num;
   for (;;) {
+    gint32 tmp_prev_ref_frame_num = priv->frame_num;

I wonder if we should execute this block only if 

if (priv->frame_num != slice_hdr->fram_num) {
...

@@ +3179,3 @@
+      if (tmp_prev_ref_frame_num < 0)
+        tmp_prev_ref_frame_num += MaxFrameNum;
+      priv->prev_ref_frame_num = tmp_prev_ref_frame_num;

this assignation seems to be spurious, since the assignation is done
unconditionally below.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.