[Bug 776927] gl: gldownload: convert GstGLMemory to GstDmaBuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343926|none                        |reviewed
             status|                            |

--- Comment #21 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 343926:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=343926)

::: ext/gl/gstgldownloadelement.c
@@ +162,3 @@
 }

+#if GST_GL_HAVE_PLATFORM_EGL && GST_GL_HAVE_DMABUF

We don't only need compilation-time validation of the EGL and dmabuf, we must
need check it at run-time.

See, for example, this patch that I hope to merge today in gstreamer-vaapi

https://github.com/ceyusa/gstreamer-vaapi/commit/0bdb0f98ad02775bf6de8d7bd52fc0e86ed4dd62

So, if your current GL context is EGL and it provides eglExportDMABUFImageMESA,
then you could enable and negotiate dmabuf to downstream.

@@ +317,3 @@
+#if GST_GL_HAVE_PLATFORM_EGL && GST_GL_HAVE_DMABUF
+  if (!features || gst_caps_features_contains (features,
+          GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY)) {

We should add  memory:DMABuf in the gldownload src template caps, but only if
the GL context is EGL with dmabuf export support, otherwise that caps should be
blacklisted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.