[Bug 775615] decodebin3: Select default track by GstStreamFlags

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 6 01:30:38 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=775615

--- Comment #22 from HoonHee Lee <hoonh83.lee at gmail.com> ---
(In reply to Edward Hervey from comment #20)
> Review of attachment 344712 [details] [review]:
> 
> ::: gst/playback/gstdecodebin3.c
> @@ +1102,3 @@
> + * GCompareFunc to use with lists of GstStream.
> + * Sorts GstStreams by mime type and select flag and stream-id
> + * First video, then audio, then others.
> 
> I'm fine with ordering by type and flags. I was just pointing out that we
> don't need a specific order for the stream type ordering.
> 
> i.e. Don't use va and vb. Just use typea and typeb directly.

As your comment, I used typea and typeb directly instead of using va and vb.
IMHO, It would be better and good to see for all developers if all streams are
ordered by video, audio, text and others. Also, it is not easy to recognize if
all streams are not ordered and complicated.

Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list