[Bug 777506] vaapidecoder_h264: Recursive loop and segfault after a few seconds

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777506

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345008|none                        |reviewed
             status|                            |

--- Comment #15 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 345008:
 --> (https://bugzilla.gnome.org/review?bug=777506&attachment=345008)

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +3172,3 @@
+      priv->frame_num -= MaxFrameNum;
+
+    if (slice_hdr->frame_num - priv->frame_num - 1 > sps->num_ref_frames)

is that -1 correct? it wasn't before, nor in the libav code.

@@ +3176,3 @@
+
+    if (priv->frame_num < 0)
+      priv->frame_num += MaxFrameNum;

in the libav this conditional is nested in the above if... is this correct?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.