[Bug 751606] audiobasesrc, audiobasesink: incorrect ringbuffer refcount when create_ringbuffer returns a non-floating ref

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751606

George Kiagiadakis <gkiagia at tolabaki.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gkiagia at tolabaki.gr

--- Comment #3 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Not that I want to be an advocate of floating references (I hate them), but in
this case I think there is no real problem. If create_ringbuffer() returns a
ringbuffer with a non-floating reference, it means that this reference is held
by the ringbuffer subclass (transfer none = the caller should not consume any
existing reference), so gst_object_ref_sink will add a new reference to be held
by the parent and everything is fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.