[Bug 778250] vaapi: build: support meson

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778250

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345067|none                        |needs-work
             status|                            |

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 345067:
 --> (https://bugzilla.gnome.org/review?bug=778250&attachment=345067)

I had to make some changes in order to make it work. In the comments are those
changes.

And, bikeshedding a bit, there a couple of trailing white spaces that we could
remove.

::: gst-libs/gst/base/meson.build
@@ +15,3 @@
+  version : libversion,
+  soversion : soversion,
+  install : true,

install : false,

::: gst-libs/gst/vaapi/Makefile.am
@@ +25,3 @@
     -DIN_LIBGSTVAAPI_CORE            \
     -DGST_USE_UNSTABLE_API            \
+    -DHAVE_GSTVAAPIVERSION_H        \

Is this a workaround because meson cannot generate the version header yet?

::: gst-libs/gst/vaapi/meson.build
@@ +204,3 @@
+endif
+if USE_EGL
+  gstlibvaapi_deps  += [egl_dep]

this needs the glib's gmodule dependency. Or better yet, delete that dead code.

@@ +222,3 @@
+  version : libversion,
+  soversion : soversion,
+  install : true,

install : false,

::: gst/vaapi/meson.build
@@ +46,3 @@
+  include_directories : [configinc, libsinc],
+  dependencies : [gstbase_dep, gstvideo_dep, gstallocators_dep,
gstpbutils_dep,
+    libva_dep, gstlibvaapi_dep, gstgl_dep],

we need libm_dep too

::: meson.build
@@ +30,3 @@
+gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req,
+    fallback : ['gst-plugins-base', 'video_dep'])
+gstcodecparsers_dep = dependency('gstcodecparsers-1.0', version : gst_req,

the dependency name is gstreamer-codecparsers-1.0

@@ +32,3 @@
+gstcodecparsers_dep = dependency('gstcodecparsers-1.0', version : gst_req,
+    fallback : ['gst-plugins-bad', 'gstcodecparsers_dep'], required: false)
+gstgl_dep = dependency('gstgl-1.0', version : gst_req,

the dependency name is gstreamer-gl-1.0

@@ +36,3 @@
+libva_dep = dependency('libva', version: '>= 0.30.4', required: false)
+
+if libva_dep.found() 

Why not, instead of branching, make libva a required dependency?

@@ +37,3 @@
+
+if libva_dep.found() 
+  cc = meson.get_compiler('c')

add libm_dep = cc.find_library('m', required : true)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.