[Bug 778283] New: gst-libav 1.8.3 loses encoders/decoders vs 1.8.2 when built with system ffmpeg 2.8.10

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778283

            Bug ID: 778283
           Summary: gst-libav 1.8.3 loses encoders/decoders vs 1.8.2 when
                    built with system ffmpeg 2.8.10
    Classification: Platform
           Product: GStreamer
           Version: 1.8.3
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-libav
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: laney at ubuntu.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Someone reported this on Launchpad at http://pad.lv/1661842

The decoders for wma/tta/ape/others are missing, as well as some encoders too.
Will attach the diff.

It was introduced with 70c281b545a383d45ec2fca296ce2387e1eac59e. The problem is
that in 2.8.10, we have "AV_CODEC_ID_PCM_S16BE_PLANAR =
MKBETAG('P','S','P',16)" - with 3.2 it changed to a different (sequential)
value, so things are okay there. It's not safe to do range comparisons on it
for 2.8. It's this part:

+    /* no quasi codecs, please */
+    if […]
+        (in_plugin->id >= AV_CODEC_ID_PCM_S8_PLANAR &&
+            in_plugin->id <= AV_CODEC_ID_PCM_S16BE_PLANAR)) {

That causes these to be thrown out.

Any suggestion for how to fix? Maybe just don't do this on old libavcodec?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.