[Bug 778250] vaapi: build: support meson

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778250

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345136|none                        |needs-work
             status|                            |

--- Comment #9 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 345136:
 --> (https://bugzilla.gnome.org/review?bug=778250&attachment=345136)

::: gst-libs/gst/base/meson.build
@@ +15,3 @@
+  version : libversion,
+  soversion : soversion,
+  install : false,

nitpick: 'install: false' is the default, so perhaps we could just remove it
(less code to maintain).

::: gst-libs/gst/vaapi/gstvaapidisplay.c
@@ +36,3 @@
 #include "gstvaapidisplay_priv.h"
 #include "gstvaapiworkarounds.h"
+#ifdef HAVE_GSTVAAPIVERSION_H

I guess this header can be autogenerated with custom_target()

::: gst-libs/gst/vaapi/meson.build
@@ +222,3 @@
+  version : libversion,
+  soversion : soversion,
+  install : false,

ditto

::: meson.build
@@ +60,3 @@
+GLES_VERSION_MASK += glesv3_dep.found() ? 8 : 0
+
+USE_ENCODERS = libva_dep.version().version_compare('>= 0.34.0')

It is missing to honor the 'with_encoders' option

USE_ENCODERS = libva_dep.version().version_compare('>= 0.34.0') and
get_option('with_encoders') != 'no'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.