[Bug 763326] gst-launch of 8-channel deinterleave pipeline stalls

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763326

--- Comment #18 from abhimanyu.v at imgtec.com ---
Review of attachment 324129:
 --> (https://bugzilla.gnome.org/review?bug=763326&attachment=324129)

::: gst/interleave/deinterleave.c
@@ -568,42 +569,62 @@
-    GstPad *ourpad = GST_PAD (l->data);
-    GstCaps *peercaps = NULL, *ourcaps;
-    GstCaps *templ_caps = gst_pad_get_pad_template_caps (ourpad);
... 39 more ...
+    switch (res) {
+          /* Only ask for peer caps for other pads than pad
+        ourcaps = gst_caps_copy (templ_caps);
... 59 more ...

Shouldnt this line be not present as ret is already initialised with any caps.
Also if we keep empty then in case of resync, it try to intersect and result in
always empty.

In our setup, which uses appsrc with deinterleave element, this line causes
caps to return empty (sometime) which in turn in  gstbasetranform.c:2913, cause
it to fail the check which then return empty caps and caps negotiation fails.
Is changing to empty instead of any is correct here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.