[Bug 778397] Iosassetsrc lacks orientation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778397

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345341|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 345341:
 --> (https://bugzilla.gnome.org/review?bug=778397&attachment=345341)

::: sys/applemedia/iosassetsrc.m
@@ +317,3 @@
+                [GST_IOS_ASSET_SRC_ASSET(src) orientation]),
+            NULL));
+    gst_pad_push_event(gst_element_get_static_pad(GST_ELEMENT(src), "src"),
orientation_event);

This is leaking the pad, also GST_BASE_SRC_PAD(src) should work

You also have to make sure to merge tag lists. If there are any others provided
by this element (are there?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.